[Coquelicot] Some patches
Antonio Terceiro
terceiro at softwarelivre.org
Tue Jul 24 14:36:10 CEST 2018
FWIW, I have read the patches and they look good to me. The only issue I have
is below:
On Tue, Jul 24, 2018 at 10:32:18AM +0200, ng wrote:
> @@ -142,7 +155,9 @@ module Coquelicot
> def read_link(src)
> File.open(links_path) do |f|
> until f.eof?
> - return $1 if f.readline =~ /^#{Regexp.escape(src)}\s+(.+)$/
> + if m = f.readline.match(/^#{Regexp.escape(src)}\s+(.+)$/)
> + return m[1]
> + end
> end
> end
> nil
This is unrelated to the lockfile usage refactoring patch, even though it's IMO
a change that makes the code more clear. I would put it into a separate patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listes.potager.org/pipermail/coquelicot/attachments/20180724/4e620a81/attachment.sig>
More information about the Coquelicot
mailing list