Hi Konrad,
Konrad Mohrfeldt:
ping?
Really sorry I haven't replied to you earlier. I'm glad you've pinged us again, your initial email was lost in travel and too much backlog.
On 18.10.2016 23:27, Konrad Mohrfeldt wrote:
i’m konrad and i just reworked a lot of haml/sass/js code from the coquelicot codebase :). we currently use coquelicot from the debian repositories on teilen.systemausfall.org and i wanted to support mobile devices for our users.
you can find the code here: https://git.hack-hro.de/kmohrf/coquelicot/tree/redesign
i would like to see these changes in the upstream repository and also have plans to work on the js codebase some more. but before i do that i would like to hear if anyone of the current maintainers and/or contributors has some comments on my progress and the changes i’ve made.
I've never been a good web developper, so I'm really happy to see your attempt to improve Coquelicot. Mobile support is especially welcome. :)
I'm not sure what kind of feedback you want on the current redesign. It's already quite an improvement! There's probably a few things which I would like to discuss, like loosing the byte counters that were displayed with the progress bar, but it's not clear to me how ready was the proposal.
if you’re fine with what you’re seeing now i would start to implement a modern js-build-stack. this would include:
- javascript build dependencies managed by npm
- a es6/es-2015 codebase based on modules
- a minified javascript distribution build via webpack
what i’ve liked about the current codebase is that i could just start changing things after i installed the ruby deps. i’m not sure i can achieve the same thing with the javascript-build like you did with the sass integration (auto-rebuilds on change). but what is surely missing from the current javascript codebase are modularity and tests and this would be a start.
As a Debian developper, my primary deployment target is Debian. So any external JavaScript library needs to be packaged in Debian before Coquelicot can depend on it.
With that in mind, I would not necessarily be opposed to using npm—Coquelicot is already using Bundler—but it should be as straightforward as possible to use, develop and deploy. As I don't have any real experience with it, I can't really judge how good is it.
Please tell me if you need more help from me to enable you to improve Coquelicot! :)