24 Jul
2018
24 Jul
'18
2:36 p.m.
FWIW, I have read the patches and they look good to me. The only issue I have is below: On Tue, Jul 24, 2018 at 10:32:18AM +0200, ng wrote:
@@ -142,7 +155,9 @@ module Coquelicot def read_link(src) File.open(links_path) do |f| until f.eof? - return $1 if f.readline =~ /^#{Regexp.escape(src)}\s+(.+)$/ + if m = f.readline.match(/^#{Regexp.escape(src)}\s+(.+)$/) + return m[1] + end end end nil
This is unrelated to the lockfile usage refactoring patch, even though it's IMO a change that makes the code more clear. I would put it into a separate patch.